Skip to content

re-initialize inputs on each execution in executor_runner #9340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

re-initialize inputs on each execution in executor_runner #9340

merged 2 commits into from
Mar 18, 2025

Conversation

swolchok
Copy link
Contributor

See NOTE for reasoning; request changes if wrong or unclear.

@swolchok
Update
5cb625a 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 17, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9340

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac789ab with merge base f351ec2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
swolchok added a commit that referenced this pull request Mar 17, 2025
@swolchok
re-initialize inputs on each execution in executor_runner
688d2a5 
See NOTE for reasoning; request changes if wrong or unclear.

ghstack-source-id: 65b039eca5fe4fa0e10e8af9fc646f2b08a2ef7e
ghstack-comment-id: 2731145978
Pull Request resolved: #9340
@swolchok
Update
ac789ab 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Mar 17, 2025
Merged
@swolchok swolchok added the release notes: devtools Changes to dev tooling, for example the debugger & profiler label Mar 17, 2025
This was referenced Mar 18, 2025
Merged
Merged
Merged
@swolchok swolchok merged commit f805940 into main Mar 18, 2025
80 of 81 checks passed
@swolchok swolchok deleted the gh/swolchok/374/head branch March 18, 2025 16:18
@shoumikhin
Copy link
Contributor

@swolchok ptal if this trunk CI failure is related https://hud.pytorch.org/pytorch/executorch/commit/f80594037f1fcdc28d4f6bab826f7d3d5be594bd

@swolchok
Copy link
Contributor Author

@swolchok ptal if this trunk CI failure is related https://hud.pytorch.org/pytorch/executorch/commit/f80594037f1fcdc28d4f6bab826f7d3d5be594bd

seems unlikely as it's a failure during building

@swolchok
Copy link
Contributor Author

https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=arm-reference&mergeLF=true says it started the commit before this one

oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
@swolchok @oscarandersson8218
re-initialize inputs on each execution in executor_runner (pytorch#9340)
b18bfe7 
See NOTE for reasoning; request changes if wrong or unclear.
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
@swolchok @DannyYuyang-quic
re-initialize inputs on each execution in executor_runner (pytorch#9340)
7c267e6 
See NOTE for reasoning; request changes if wrong or unclear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: devtools Changes to dev tooling, for example the debugger & profiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swolchok @shoumikhin @manuelcandales @facebook-github-bot